[secp256k1] Update secp256k1 from 2017 to 2022 #25398
Conversation
…ast year. - Edit CMakeList.txt to target precomputed library. - Edit libsecp256k1-config.h to undef and define VARS compilation. - Edit portfile.cmake to download new sources from repository, commit reference 44c2452fd387f7ca604ab42d73746e7d3a44d8a2 (bitcoin-core/secp256k1) - Edit vcpkg.json to new version portfile
…ast year >> vcpkg x-add-version secp256k1 - Update secp256k1.json version - Update baseline.json version
JonLiu1993
added
the
category:port-update
JonLiu1993
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
You have modified or added at least one portfile where deprecated functions are used.
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}The following files are affected:
ports/secp256k1/portfile.cmake
You have modified or added at least one vcpkg.json where you should check the license field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/secp256k1/vcpkg.json
Valid values for the license field can be found in the documentation
Added JonLiu1993 suggestion. Put PREFER_NINJA to secp256k1/portfile.cmake Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
There was a problem hiding this comment.
JonLiu1993
This changes makes a regression.
https://github.com/microsoft/vcpkg/pull/25398/checks?check_run_id=7027450457
Regression resolved!
3e6ebcf
Running the command:
vcpkg x-add-version secp256k1
git add versions
git commit -m "Update version database"
Added JonLiu1993 suggestion. Put dependencies to secp256k1/vcpkg.json Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
>> vcpkg x-add-version secp256k1
>> vcpkg format-manifest ports/secp256k1/vcpkg.json
vcpkg x-add-version secp256k1
There was a problem hiding this comment.
You have modified or added at least one portfile where deprecated functions are used.
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}The following files are affected:
ports/secp256k1/portfile.cmake
You have modified or added at least one vcpkg.json where you should check the license field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/secp256k1/vcpkg.json
Valid values for the license field can be found in the documentation
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where you should check the license field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/secp256k1/vcpkg.json
Valid values for the license field can be found in the documentation
JackBoosY
added
depends:upstream-changes
JackBoosY
changed the title
JackBoosY
added
info:reviewed
Update port unnoficial-secp256k1
What does your PR fix?
Fixes #
Update the commit reference to bitcoin-core/secp256k1 project to 2022, to keep the portability with VCPKG project.
Which triplets are supported/not supported? Have you updated the CI baseline?
Linux, Windows
CI tested triplets:
x64-linux
x64-windows
x64-windows-static
x86-windows
Others, was skipped.
Does your PR follow the maintainer guide?
Whithout necessity of maintanance of main VCPGK project
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes, commited!